Skip to content

Add utility method to check if macro is inside table #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GustavoViniciusdeMorais

Check if macro is inside table

It was added a function to verify if the macro used to clone a table row inside the document is inside a table to avoid the bug 'Can not find the start position of the row to clone.'

It gives to the user of the library a way to avoid the throw of a new exception and continue processing the document without an error caused by a mistake from his client.

Fixes # (improvement)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)

@troosan
Copy link
Contributor

troosan commented Apr 13, 2021

please fix style issues

@troosan troosan added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Apr 13, 2021
@troosan troosan changed the title check if macro is inside table Add utility method to check if macro is inside table Apr 15, 2021
@troosan troosan added Template Processor and removed Status: Waiting for feedback Question has been asked, waiting for response from PR author labels Apr 15, 2021
@troosan troosan modified the milestones: v0.18.2, v0.19.0 Apr 15, 2021
@Progi1984 Progi1984 removed this from the v1.0.0 milestone Nov 16, 2022
@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:15
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants