WIP Do Not Install #2567
Draft
WIP Do Not Install #2567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All my unimplemented changes. Not intended for install.
Better from a technical standpoint. Pre-processing much simplified. Some post-processing added because loadHTML preserveWhiteSpace=false does not work well. Not-UTF8 html can now be loaded. No need to surround snippets with body tag.
It's debatable, but allow unescaped ampersand and unknown charset.
Because we still have to support Php 7.1 :-( The reason Php 7.1 has succeeded in its unit tests till now is because symfony/polyfill-php72 is added during its Composer install step. This undocumented dependency should not be relied on.
It will only be loaded for Php7.1 which we still support.
Should be my last change here for a while.
Corresponding to Php7.* and Php8.0. Did not seem to recognize runInSeparateProcess for test method.
Not sure why this should be needed for Phpunit 9 but not 10. No harm specifying it in 10.
Writer/Html/FontTest was already bad, testing for the wrong default font values because a prior test had overlaid those; a full unit test would succeed, but just testing the Writer/Html directory would not. Better test planning eliminates that possibility, without the need to resort to resource-intensive separate processes.
PhpWordTest tries to save as if it were a browser even though that is not the case. This causes a problem for Phpunit 9 (Php 7.* or 8.0) if not run in separate process. So let it run separate. No harm for Php8.1+, except for a slight performance penalty.
Removed from Element and Reader tests. Style and Writer remain for now.
All call getRemoteGifImageUrl. Try setting those methods to separate process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All my unimplemented changes. Not intended for install.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported