Conversation
mseaton
reviewed
Feb 18, 2022
Member
mseaton
left a comment
mseaton
left a comment
There was a problem hiding this comment.
@lnball see my comments on the ticket, but this is just test data that is only loaded for unit testing. It will never make it onto any system. Note that both of the files you changed are in the “src/test/resources” folder. The reason why things fail when you made the changes you did, is because you removed the concept_reference_source entries, but did not remove all of the concept_reference_terms that refer to these sources. Search for concept_source_id="11" and you'll see what I mean.
I recommend we close this PR and not merge it in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ticket for more information. This is messy with updates in 2 modules and some issues.