Skip to content

replace requested_mean argument to mean #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shahronak47 wants to merge 1 commit into
base: DEV
Choose a base branch
from
Open

replace requested_mean argument to mean #237

shahronak47 wants to merge 1 commit into from

Conversation

@shahronak47
Copy link
Contributor

@shahronak47 shahronak47 commented Jan 24, 2024

For PIP-Technical-Team/pipapi#393 we want to replace requested_mean argument to mean. I have also exported the function gd_compute_pip_stats as we are using it in pipapi now.

@randrescastaneda
Copy link
Member

randrescastaneda commented Jan 24, 2024

Hi @tonyfujs ,

For testing purposes, I tested Ronak's branch, update-for-api, into the branch refactor_consistency. I only got one conflict merge in NAMESPACE, which was easily solved. Then I ran the tests and all passed. So, I think we can safely accept the PR in #236, which merged refactor_consistency into DEV, and then approve this PR into DEV again. In principle, the only conflict to solve in the one in the NAMESPACE.

Thanks.
Best,

@randrescastaneda randrescastaneda requested review from tonyfujs and removed request for randrescastaneda January 24, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyfujs tonyfujs Awaiting requested review from tonyfujs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shahronak47 @randrescastaneda