Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
prqlquery header that repeats an argument now fails withduplicate query definition argumentsinstead of quietly using the last value. Before this,query_defcollected the header's arguments into aHashMap, so each repeat overwrote the earlier value. This compiles with Postgres'sLIMIT, not MSSQL'sTOP:The same applies to
version: inprql version:"0.1" version:"^0.13"the0.1requirement, which the compiler would otherwise reject, was discarded without a message.The new error points at the header span and names every repeated argument, matching the existing
unknown query definition argumentsdiagnostic next to it. The regression testquery_def_duplicate_argumentinprqlc-parser/src/parser/stmt.rsfails without the check and passes with it. Locally,cargo test -p prqlc-parserandcargo clippy -p prqlc-parser --all-targets -- -D warningsboth pass.Found by the nightly survey of
prqlc-parser/src/parser/stmt.rs.