-
Notifications
You must be signed in to change notification settings - Fork 0
🚀 Add KeyVaultKeyReference parameter for GitHub App authentication #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: MariusStorhaug <[email protected]>
Add a test that proves the keyvaultkeyreference logon type is working. Assume there is an environment with AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_SUBSCRIPTION_ID variables (vars) are available. Assume that the variable KEYVAULT_KEY_REFERENCE is also available. |
Co-authored-by: MariusStorhaug <[email protected]>
Added test |
.github/workflows/TestWorkflow.yml
Outdated
|
||
# Login to Azure to enable KeyVault access | ||
- name: Login to Azure | ||
uses: azure/login@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update it to v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated azure/login action from v1 to v2 as requested. (b256dc3)
Co-authored-by: MariusStorhaug <[email protected]>
|
||
# Login to Azure to enable KeyVault access | ||
- name: Login to Azure | ||
uses: azure/login@v2 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
This PR adds support for authenticating GitHub Apps using Azure KeyVault key references, enabling secure private key storage in Azure KeyVault instead of GitHub secrets.
Changes Made
🔧 Core Implementation
KeyVaultKeyReference
input parameter with proper description and environment variable mappingPrivateKey
andKeyVaultKeyReference
ClientID
must be provided with exactly one key parameterConnect-GitHub -ClientID <ClientID> -KeyVaultKeyReference <url>
📚 Documentation
KeyVaultKeyReference
to inputs documentation tableazure/login
action for KeyVault authenticationUsage Example
Validation
The implementation includes comprehensive validation:
PrivateKey
orKeyVaultKeyReference
can be providedClientID
must be provided with exactly one key parameterAuthentication Flow
The action now supports three authentication methods:
Token
parameter (existing)ClientID
+PrivateKey
(existing)ClientID
+KeyVaultKeyReference
(new)Fixes #62.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.