Added shared types folder for playground examples & typechecking on CI #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InosRahul
requested review from
eli7pm,
miguelcalderon,
sashamilenkovic and
veroo-m
InosRahul
changed the title
miguelcalderon
approved these changes
Dec 10, 2025
Contributor
miguelcalderon
left a comment
miguelcalderon
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for taking care of this! 🙇
veroo-m
approved these changes
Dec 10, 2025
.github/workflows/typecheck.yml
Outdated
| jobs: | ||
| typecheck: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 |
Collaborator
There was a problem hiding this comment.
Nit 10 min is a bit much for a type check time out no?
.github/workflows/typecheck.yml
Outdated
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' |
Collaborator
There was a problem hiding this comment.
how about always using latest version here?
Contributor
Author
There was a problem hiding this comment.
Yes makes sense. Added LTS version in this commit: 6d86220
playground/annotations/flatten-annotations-on-create/playground.mdx
Outdated
Show resolved
Hide resolved
miguelcalderon
approved these changes
Dec 10, 2025
Contributor
miguelcalderon
left a comment
miguelcalderon
left a comment
There was a problem hiding this comment.
Commented instead of approving 🙈 Approved now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
CI: