Remove Nutrient assets copy requirement from examples. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veroo-m
approved these changes
May 29, 2025
Comment on lines
+50
to
+53
| "predev": "npm run copy-files", | ||
| "dev": "tsc", | ||
| "start": "serve -l 8080 ./dist", | ||
| "prestart:dev": "node bin/verify-install.js", | ||
| "prestart:dev": "npm run copy-files", |
There was a problem hiding this comment.
do we need two different scripts to run npm run copy-files?
There was a problem hiding this comment.
The pre prefixed scripts run before the start:dev and dev scripts respectively, that's the reason they're repeated, to make sure they run before building on each mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://pspdfkit.atlassian.net/browse/WEB-2319
Details
Remove the copy assets step from the Web examples where possible using strategies as close to each framework's recommended practices as possible.
These changes will be reflected in the corresponding "Getting started" guides in the Website repo as part of the same task.
Examples are being updated to match as closely as possible the new instructions in the guides, opting in some cases for the CDN approach, or for the framework-specific local installation approach as it seemed easier or more helpful for readers.
Some integrations like ASP.NET and Blazor have been left alone because of the nature of the integration, which would not involve the use of a JavaScript package manager so the complexity of the setup, if any, is already built in and trying to make it easier would involve providing more instructions than simply asking to copy the corresponding assets as it is now.
Others were already free of the assets copying step.
Some minor tasks have been included here, like updating some vulnerable dependencies and minor edits.