Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual RC trim calibration and add FW_ prefix to trim parameters #22966

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Apr 3, 2024

Solved Problem

With #22668 we introduce a new way of automatically trimming out a FW vehicle (or a VTOL in FW). This makes the legacy way of trimming a plane manually quite redundant, and thus I propose to remove it here. Also helps to advise for a consistent bring up process: first flight in Stabilized mode --> trims are stored --> also applied in the following manual flights.

Solution

  • remove manual RC trimming functionality
  • rename TRIM_ROLL/PITCH/YAW-> FW_TRIM_ROLL/PITCH/YAW to make it clear that those are the FW trims

Changelog Entry

For release notes:

Improvement: Remove manual RC trim calibration and add FW_ prefix to trim parameters.

FYI @MaEtUgR @dagar as discussed in the devcall yesterday.

Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me but we should be sure that no one is really using that feature. @ryanjAA Are you using the manual trimming feature of QGC? (i.e.: save RC trims back to params)

@ryanjAA
Copy link
Contributor

ryanjAA commented Apr 4, 2024

Thanks for thinking of me. We use the control allocator trim field on every aircraft and manually set the wheel trim via pwm min and max (no other way for wheel). We don’t do it from the RC trim copy feature from the RC remote so as long as that isn’t gone 🙏🏻.

@sfuhrer
Copy link
Contributor Author

sfuhrer commented Apr 8, 2024

Let's check if QGC still uses it (I assume so), and if so then remove it from there first.

@github-actions github-actions bot added the stale label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

3 participants