avoid executable being rebuilt on every "catkin_make" call#39
Open
nikolausmayer wants to merge 1 commit intoPX4:dynamic-reconfigurefrom
Open
avoid executable being rebuilt on every "catkin_make" call#39nikolausmayer wants to merge 1 commit intoPX4:dynamic-reconfigurefrom
nikolausmayer wants to merge 1 commit intoPX4:dynamic-reconfigurefrom
Conversation
…uilt on every catkin_make call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filename of
cfg/uvc_ros_driver_node.cfgdoes not match theUvcDriverin the last line of that fileexit(gen.generate(PACKAGE, "uvc_ros_driver", "UvcDriver"))which makes
catkin_makere-generate the dynamic-reconfigure header every time.cfg/uvc_ros_driver_node.cfgtocfg/UvcDriver.cfgto matchCMakeLists.txtaccordinglyExisting depending code does not need to be changed (the generated header file remains the same).