-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] Allow wasm binary path on config #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
fermuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Type
enhancement, tests, documentation
Description
Allow configuration of WASM binary path in
numscriptex.Add test for custom WASM binary path configuration.
Update documentation to include
:binary_pathconfiguration.Changes walkthrough 📝
assets_manager.ex
Add configurable binary path for WASM filelib/numscriptex/assets_manager.ex
@default_binary_pathfor default WASM path.@binary_pathconfigurable via application environment.binary_pathfunction to use application environment.assets_manager_test.exs
Add test for custom binary path configurationtest/numscriptex/assets_manager_test.exs
README.md
Document `:binary_path` configuration optionREADME.md
:binary_pathconfiguration option.:binary_path.