You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The call to AssetsManager.ensure_wasm_binary_is_valid() has been moved. Ensure that this change does not affect the initialization sequence or introduce any side effects.
The function maybe_drop_balance has been changed to private. Verify that this change does not affect any external modules or tests that might rely on this function.
Why: The suggestion addresses a critical issue by ensuring that potential errors from the AssetsManager.ensure_wasm_binary_is_valid() call are handled, which can prevent unexpected behavior or crashes in the application.
8
fermuch
changed the title
[FEAT] inspect before publishing (CU #86b37qg8h)
[FEAT] review before publishing (CU #86b37qg8h)
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Caso alguma mudança seja solicitada após ispeção, será feita a partir desse PR.
Como não tinha uma task específica pra configurar a metadata de Hex Docs, aproveitei e subi as mudanças aqui também.
Task: https://app.clickup.com/t/86b37qg8h
PR Type
enhancement, documentation
Description
Added MIT license to the project.
Improved documentation with detailed type annotations.
Updated Elixir version and dependencies in
mix.exs.Enhanced code readability and consistency.
Changes walkthrough 📝
numscriptex.ex
Enhance documentation and ensure WASM binary validitylib/numscriptex.ex
balances.ex
Improve documentation and make function privatelib/numscriptex/balances.ex
maybe_drop_balancefunction private.check_log.ex
Add detailed type documentationlib/numscriptex/check_log.ex
log_levelstype for clarity.run.ex
Improve documentation and error message claritylib/numscriptex/run.ex
LICENSE
Add MIT license fileLICENSE
README.md
Improve documentation and add license informationREADME.md
mix.exs
Update project metadata and dependenciesmix.exs
ex_docdependency for documentation.run_test.exs
Update test assertions and descriptionstest/numscriptex/run_test.exs