fix: deleted posts still visible after removal (#3602) #3695
Conversation
WalkthroughThis pull request updates the asynchronous post deletion functionality in the UserPortal. The Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant PC as PostCard Component
participant D as deletePost Service
participant T as Toast Service
U->>PC: Clicks delete action
PC->>D: await deletePost()
D-->>PC: Returns event data
PC->>PC: Check if event data exists
alt Event data present
PC->>PC: Call fetchPosts()
PC->>T: Display success toast
else No event data
PC-->>PC: End process
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@AryanSwaroop Please fix the failed tests. |
|
@Cioppolo14 that test failure is not related to this issue ! I can solve it, by raising another, @palisadoes merged my PR yesterday. |
|
Please fix the test in this PR |
|
On it then! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3695 +/- ##
=================================================
Coverage 86.08% 86.08%
=================================================
Files 371 371
Lines 9138 9139 +1
Branches 1925 1926 +1
=================================================
+ Hits 7866 7867 +1
Misses 906 906
Partials 366 366 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
Ensures Deleted Posts Are No Longer Visible in posts section of user portal.
Issue Number:
#3602
Snapshots/Videos:
Video_250215115245.mp4
If relevant, did you update the documentation?
No
Summary
A issue like this can cause confusion for any individual using talawa services as if post is not deleted then they might delete some other post in confusion.
Does this PR introduce a breaking change?
There is not any breaking change just a simple awaiting till data is updated.
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit