Skip to content

chore: removed ingress_domains input from doc #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

uptownhr
Copy link
Member

@uptownhr uptownhr commented Apr 8, 2025

Important

Remove ingress_domains input from inbound networking guide documentation.

  • Documentation:
    • Removed ingress_domains input from index.mdx in the inbound networking guide.

This description was created by Ellipsis for da845de. It will automatically update as commits are pushed.

@uptownhr uptownhr requested a review from fullykubed as a code owner April 8, 2025 17:58
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to da845de in 40 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. packages/website/src/content/docs/main/guides/bootstrapping/inbound-networking/index.mdx:183
  • Draft comment:
    Removed ingress_domains input and comment. Ensure related docs/modules have been updated accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to ensure that related documentation and modules have been updated, which falls under the rule of not asking the author to ensure things. This is not a specific code suggestion or a request for a test, so it should be removed.
2. packages/website/src/content/docs/main/guides/bootstrapping/inbound-networking/index.mdx:184
  • Draft comment:
    Removed the ingress_domains input and its accompanying comment. Confirm that this removal aligns with module updates and that any external references have been updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_mDQ7JjOp7G09OoEU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant