fix(twitter): extract cookie parsing into helper function#196
Merged
Panniantong merged 1 commit intomainfrom Mar 23, 2026
Merged
fix(twitter): extract cookie parsing into helper function#196Panniantong merged 1 commit intomainfrom
Panniantong merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased version of PR #190 by @srxly888-creator — thank you for the contribution! 🎉
Extracts the Twitter cookie parsing logic from
_cmd_configure()into a standalone_parse_twitter_cookie_input()function, improving maintainability and testability.Changes
agent_reach/cli.py: Extract cookie parsing into_parse_twitter_cookie_input()tests/test_cli.py: Add 2 test cases for cookie parsing (separate values + header string)Tests
✅ All 10 CLI tests pass after rebase onto latest main (post bird migration).
Closes #191
Supersedes #190
Co-authored-by: srxly888-creator