Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly launch WindCharges #11418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lynxplay
Copy link
Contributor

@lynxplay lynxplay commented Sep 20, 2024

The launch API on LivingEntity only respected the WindCharge type, not
its near-clone BreezeWindCharge.

This commit correctly accounts for BreezeWindCharge in
CraftLivingEntity.

Resolves: #11417


Download the paperclip jar for this pull request: paper-11418.zip

The launch API on LivingEntity only respected the WindCharge type, not
its near-clone BreezeWindCharge.

This commit correctly accounts for BreezeWindCharge in
CraftLivingEntity.
Additionally, this also ports over the entire wind charge launch logic
to BlockProjectileSource as dispensers are capable of launching wind
charges.
@lynxplay lynxplay requested a review from a team as a code owner September 20, 2024 10:40
@lynxplay lynxplay added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

BreezeWindCharge is fireball when launched instead of breeze wind charge
1 participant