Use default SpawnReason if the entity has none #13370
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
reviewed
Dec 6, 2025
| public org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason getEntitySpawnReason() { | ||
| return this.getHandle().spawnReason; | ||
| public CreatureSpawnEvent.SpawnReason getEntitySpawnReason() { | ||
| return Optional.ofNullable(this.getHandle().spawnReason).orElse(CreatureSpawnEvent.SpawnReason.DEFAULT); |
Contributor
There was a problem hiding this comment.
I think you mean Objects.requireNonNullElse(spawnReason, DEFAULT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getEntitySpawnReason is supposed to be NotNull, but can return null if it's called on an entity at a bad time (i.e. in an event before the entity is fully added to the world). This PR makes it return DEFAULT in such cases to indicate that it's missing a spawn reason.