Reimplement int based gamerule access #13372
Merged
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplementation of the <=1.21.10 changes to move game rule reads/writes to a plain array access instead of a hashmap. The implementation did not fully remove the backing hashmap, instead it is kept up-to-date on writes. This decision aims to reduce the diff needed for this change. The backing map is required in the codec, merging operations and copies. This means that writes carry the overhead of updating the map, however they should be rare enough to not actually matter.
masmc05
reviewed
Dec 6, 2025
paper-server/patches/sources/net/minecraft/world/level/gamerules/GameRule.java.patch
Outdated
Show resolved
Hide resolved
Machine-Maker
approved these changes
Dec 6, 2025
github-project-automation
bot
moved this from Awaiting review
to Merged
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplementation of the <=1.21.10 changes to move game rule reads/writes
to a plain array access instead of a hashmap.
The implementation did not fully remove the backing hashmap, instead
it is kept up-to-date on writes. This decision aims to reduce
the diff needed for this change. The backing map is required in the
codec, merging operations and copies.
This means that writes carry the overhead of updating the map, however
they should be rare enough to not actually matter.