Add support for FunctionsApplicationBuilder #685
+296
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bording
force-pushed
the
functions-application-builder
branch
from
ec04e93 to
d1dfe23
Compare
tamararivera
approved these changes
Sep 22, 2025
| public static Microsoft.Extensions.Hosting.IHostApplicationBuilder AddNServiceBus(this Microsoft.Extensions.Hosting.IHostApplicationBuilder builder, string endpointName, System.Action<Microsoft.Extensions.Configuration.IConfiguration, NServiceBus.ServiceBusTriggeredEndpointConfiguration> configurationFactory) { } | ||
| public static Microsoft.Extensions.Hosting.IHostApplicationBuilder AddNServiceBus(this Microsoft.Extensions.Hosting.IHostApplicationBuilder builder, string endpointName, string connectionString, System.Action<Microsoft.Extensions.Configuration.IConfiguration, NServiceBus.ServiceBusTriggeredEndpointConfiguration> configurationFactory) { } | ||
| public static Microsoft.Extensions.Hosting.IHostApplicationBuilder AddNServiceBus(this Microsoft.Extensions.Hosting.IHostApplicationBuilder builder, string endpointName, string connectionString = null, System.Action<NServiceBus.ServiceBusTriggeredEndpointConfiguration> configurationFactory = null) { } | ||
| public sealed class <G>$605D8CCF64349EA050C790D67C500BD9 |
There was a problem hiding this comment.
Comment: I know this is not part of your implementation, but it is a bummer that it adds a hashed value here.
| /// <summary> | ||
| /// Configures an NServiceBus endpoint that can be injected into a function trigger as a <see cref="IFunctionEndpoint"/> via dependency injection. | ||
| /// </summary> | ||
| public IHostApplicationBuilder AddNServiceBus(Action<IConfiguration, ServiceBusTriggeredEndpointConfiguration> configurationFactory) |
There was a problem hiding this comment.
Question: I know again you didn't directly wrote this, but do you happen to know why on some of the extensions we set the default value of configurationFactory to null? I expected for all to have the start value or none of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
FunctionsApplicationBuilderby addingAddNServiceBusextensions methods forIHostApplicationBuilder.Note
The previous
IHostBuilderextension methods are namedUseNServiceBus, butAddseems to be the more correct pattern to follow at this point, so the I decided to useAddfor the new methods instead keeping it consistent.