Skip to content

Addressing issues with failing flaky tests #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Oct 14, 2025
Merged

Addressing issues with failing flaky tests #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c32d8cf
Replace window.setTimeout with just setTimeout
johnsimons Sep 15, 2025
a78df4c
forks is now the default
johnsimons Oct 7, 2025
f3923b4
adding jsdom types
johnsimons Oct 7, 2025
e00aa93
Moved afterEach into the driver
johnsimons Oct 7, 2025
c928e82
Fix failing tests
johnsimons Oct 7, 2025
13f7cd3
Extract auto refresh from stores
johnsimons Oct 8, 2025
01b25e0
Rework tests based on changes
johnsimons Oct 8, 2025
bdf5b1f
Using the flush-promises from vitest api
johnsimons Oct 8, 2025
d02c45d
Installed vite-plugin-vue-devtools for diagnostics during development
johnsimons Oct 8, 2025
f41bf1a
Need to flush promises in driver too
johnsimons Oct 8, 2025
8562082
Use latest windows
johnsimons Oct 8, 2025
d9a01a1
Increase timeout slightly to 15 seconds
johnsimons Oct 9, 2025
af1b666
Remove unneeded props
johnsimons Oct 9, 2025
a20e127
Clean up the watch handler
johnsimons Oct 9, 2025
4bb15f5
Log a warning if a call comes that is not handled
johnsimons Oct 9, 2025
8bfa986
We need to pause and resume the auto-refresh
johnsimons Oct 9, 2025
c3bc851
No need to lint mockServiceWorker.js
johnsimons Oct 10, 2025
e51e1ed
Simplified start of initial refreshes
johnsimons Oct 10, 2025
001989f
Reworked the auto refresh
johnsimons Oct 13, 2025
3a0911b
Fix autoRefresh to properly handle store setting
johnsimons Oct 13, 2025
37e9f1a
Remove warning from tests
johnsimons Oct 13, 2025
a6b912c
We need to do a fetch when a component calls the refresh
johnsimons Oct 13, 2025
35c3621
Removed unnecessary test
johnsimons Oct 14, 2025
1c2ac7c
Address feedback
johnsimons Oct 14, 2025
45688bc
Swap to useTimeoutPoll given that it waits for the callback to be fin…
johnsimons Oct 14, 2025
427b594
Changes based on review feedback
johnsimons Oct 14, 2025
d307c09
Merge pull request #2658 from Particular/john/refresh_v2
johnsimons Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ defaults:
jobs:
build:
name: Windows
runs-on: windows-2022
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion src/Frontend/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended"

export default tseslint.config(
{
ignores: ["node_modules/**", "dist/**", "public/js/app.constants.js"],
ignores: ["node_modules/**", "dist/**", "public/js/app.constants.js", "public/mockServiceWorker.js"],
},
{
files: ["**/*.{js,mjs,ts,vue}"],
Expand Down
Loading