Introduced a monitoringClient and serviceControlClient #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
force-pushed
the
john/refactor_stores
branch
from
d0cad1d to
6fb9a65
Compare
Introduced a monitoringClient
johnsimons
force-pushed
the
john/refactor_stores
branch
from
f692f92 to
0efe289
Compare
PhilBastian
reviewed
Nov 28, 2025
src/Frontend/src/components/configuration/EndpointConnection.vue
Outdated
Show resolved
Hide resolved
| localMonitoringUrl.value += "/"; | ||
| } | ||
| //values have changed. They'll be reset after page reloads |
Contributor
There was a problem hiding this comment.
my understanding is that these values are used in determining the url that's actually used in the SC and monitoring clients, so wouldn't this logic still be necessary?
Contributor
There was a problem hiding this comment.
I think this is now handled in the client getUrl?
const existingScu = window.localStorage.getItem("scu");
if (scu) {
if (scu !== existingScu) {
window.localStorage.setItem("scu", scu);
}
return scu;
}
# Conflicts: # src/Frontend/src/components/failedmessages/DeletedMessages.vue # src/Frontend/src/components/failedmessages/FailedMessages.vue # src/Frontend/src/components/failedmessages/PendingRetries.vue # src/Frontend/src/stores/ServiceControlStore.ts
PhilBastian
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the client APIs from the store.
So, in this PR we make the separation to use the store as just a state management store, and the calling of the REST api is delegated to the client api.