Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.1.0 #417

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 15, 2024

Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.1.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 15, 2024
@dependabot dependabot bot requested a review from andregasser January 15, 2024 20:24
@dependabot dependabot bot force-pushed the dependabot/gradle/org.jlleitschuh.gradle.ktlint-12.1.0 branch 3 times, most recently from 776bfa3 to 1ea2f58 Compare February 7, 2024 10:11
dependabot bot and others added 2 commits February 7, 2024 23:36
Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.1.0.

---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle.ktlint
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@andregasser andregasser force-pushed the dependabot/gradle/org.jlleitschuh.gradle.ktlint-12.1.0 branch from 167cc62 to c4049b2 Compare February 7, 2024 22:36
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3e60355) 50.00% compared to head (c4049b2) 49.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #417      +/-   ##
============================================
- Coverage     50.00%   49.99%   -0.01%     
+ Complexity      775      774       -1     
============================================
  Files           176      176              
  Lines          5108     5107       -1     
  Branches        327      327              
============================================
- Hits           2554     2553       -1     
  Misses         2275     2275              
  Partials        279      279              
Files Coverage Δ
...e/src/main/kotlin/social/bigbone/MastodonClient.kt 35.69% <100.00%> (-0.17%) ⬇️
...igbone/src/main/kotlin/social/bigbone/api/Range.kt 100.00% <ø> (ø)
.../bigbone/api/method/admin/AdminDimensionMethods.kt 94.82% <ø> (ø)
...kotlin/social/bigbone/rx/RxFollowRequestMethods.kt 0.00% <0.00%> (ø)
...i/exception/BigBoneClientInstantiationException.kt 44.44% <0.00%> (ø)

@andregasser andregasser requested review from PattaFeuFeu and bocops and removed request for andregasser February 7, 2024 22:42
@andregasser
Copy link
Collaborator

Hello @bocops and @PattaFeuFeu,

This PR upgrades ktlint to the latest version. I had to disable some rules globally plus added some file-level / method-level suppressions. Not much in total. This PR makes #378 obsolete.

Could one of you quickly have a look at it? Thanks 😊

@PattaFeuFeu PattaFeuFeu merged commit 94563c5 into master Feb 8, 2024
@PattaFeuFeu PattaFeuFeu deleted the dependabot/gradle/org.jlleitschuh.gradle.ktlint-12.1.0 branch February 8, 2024 11:15
@PattaFeuFeu PattaFeuFeu mentioned this pull request Feb 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants