Fix malformed fallback streaming URL #534
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user of the library mentioned in #530 that the streaming fallback URL is malformed in that it doesn’t contain
://
, e.g.httpsmastodon.social
instead ofhttps://mastodon.social
.This PR ensures that the URL follows URL specifications by using
HttpUrl
to create a URL.To not always run the builder, I’ve put it into a lambda that is only called if the fallback URL is actually necessary.
An easier way would be to just write
$scheme://$instanceName
but I decided against it so that OKHTTPHttpUrl
is used on both ends, ensuring compatibility.Closes #530
Type of Change
Breaking Changes
How Has This Been Tested?
Warning
Not yet tested. I’m currently in the process of writing unit tests for this.
Mandatory Checklist
gradle check
and there were no errors reported