Add PKCE parameters to relevant OAuth methods #536
+70
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds parameters necessary for PKCE (Proof Key for Code Exchange) during OAuth authorization flow (see https://docs.joinmastodon.org/spec/oauth/#pkce). Specifically:
Closes #531.
Type of Change
Breaking Changes
getUserAccessTokenWithAuthorizationCodeGrant()
. Java users of the library will need to add anull
parameter (ascodeVerifier
) before a non-nullscope
parameter if not using PKCE.How Has This Been Tested?
See below. Also ran modified samples against live Mastodon servers to confirm that PKCE parameters are used and correct.
Mandatory Checklist
gradle check
and there were no errors reportedUnit tests not possible, but samples do work.
Optional checks
/docs
folder (e.g. API Coverage page)?Documentation was not yet changed back from "fully supported".