maint: Remove core/remove and core/url. #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove core/remove and core/url and it's usage in pat-slides. core/url can nowadays be replaced by the URL interface from the web API. core/remove did invoke the destroy event to invoke clean-up routines. core/remove result in an infinite recursion error in combination with the TinyMCE API due to core/remove's patching of the internal cleanData jQuery API. pat-slides is currently not in a working state, so the removal is OK. Anyways, this triggers the question how to handle Pattern cleanup in the future. The answer is in a mutation observer on document level, but this will be part of a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove core/remove and core/url and it's usage in pat-slides. core/url wasn't used at all and core/remove did invoke the event to invoke clean-up routines.
But core/remove did that by patching the internal cleanData jQuery API. This resulted in an infinite recursion error in combination with pat-tiptap from Mockup.
pat-slides is currently not in a working state, so the removal is OK. Anyways, this triggers the question how to handle Pattern cleanup in the future. The answer is in a mutation observer on document level, but this will be part of a future release.