Eliminate offset/limit parameters and improve the code for retrieving analyses #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dWithPrimaryPublication()
arteymix
force-pushed
the
feature-improve-dataset-analyses-endpoint
branch
from
80c7188 to
40dda98
Compare
Any existing uses will be reviewed
arteymix
force-pushed
the
feature-improve-dataset-analyses-endpoint
branch
from
40dda98 to
6e441be
Compare
arteymix
force-pushed
the
hotfix-1.30.2
branch
from
66519d7 to
ac1a970
Compare
Layout might need some adjustment.
arteymix
force-pushed
the
hotfix-1.30.2
branch
from
7542a30 to
810e85f
Compare
… analysis VOs Add a parameter to include analyses of subsets. Include analyses of subsets in the output of the endpoint. Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API. Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).
This reverts commit 6840804.
…trieving analysis VOs" This reverts commit 2762757.
… analysis VOs Remove unnecessary offset/limit parameters of getDatasetDifferentialExpressionAnalyses() (fix #841). Add a parameter to include analyses of subsets. Tidy up the DAO: - don't retrieve FVs for subsets if includeAnalysesOfSubsets is false - initialize proxies of both experiments and subsets Include analyses of subsets in the output of the endpoint. Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API. Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).
arteymix
force-pushed
the
feature-improve-dataset-analyses-endpoint
branch
from
6e441be to
d618129
Compare
|
Duplicate of #859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.