Conversation
|
Looks good! Could probably take the opportunity to also add the other missing new props? Looks like we don't have ws-base-url Also unrelated, but contribution-offset doesn't look be working in the preview for me is it for you? Its meant to show in the goal progress bar right? |
Good call, will add the missing fields. |
|
Cool thanks |
johnkuney
left a comment
johnkuney
left a comment
There was a problem hiding this comment.
Looks good just a few comments
components/ButtonGenerator/data.js
Outdated
| key: 'autoClose', | ||
| className: 'col_sm_center', | ||
| type: 'boolean', | ||
| default: false, |
There was a problem hiding this comment.
default should be true for autoclose
components/ButtonGenerator/index.tsx
Outdated
| opReturn: '' | ||
| opReturn: '', | ||
| contributionOffset: 0, | ||
| disableAltpayment: false |
There was a problem hiding this comment.
Make sure to include all the new props here as well with default values, otherwise they wont reset with the reset button. All the strings should just be '' and auto-close should be true
| hideToasts={button.hideToasts} | ||
| disableEnforceFocus={button.disableEnforceFocus} | ||
| contributionOffset={button.contributionOffset} | ||
| disableAltpayment={button.disableAltpayment} |
There was a problem hiding this comment.
same here. lets make sure we're adding all the new props here so the preview button has the intended functionality. Its unlikely anyone would actually test a different Api base url here, or the auto close, but should add it anyway
2 participants
Related to #
Added contributtionOffset and disableAltpayment props to paybutton generator.
Description
Test plan