Merged
Conversation
Klakurka
previously approved these changes
Jun 3, 2025
Member
There was a problem hiding this comment.
I had a feeling that this was going to work but im impressed by how well it does.
Payment latency is down to just under 1s.
We'll have to confirm that we notice a difference in prod but if that performance mostly holds up, we're going to need to investigate what's going on with our Chronik node as it shouldn't be so slow especially since we're connecting to the direct address and not going through cloudfront.
config/example-config.json
Outdated
| "https://chronik.pay2stay.com/xec2" | ||
| ], | ||
| "bitcoincash": ["https://bch.paybutton.io"] | ||
|
|
Member
|
Is there a way to easily tell which Chronik server it's connecting to? |
Collaborator
Author
It appears in the beggining, but I'll make it more clear |
Collaborator
Author
|
Added URL list to admin panel |
Klakurka
requested changes
Jun 3, 2025
| type: { | ||
| "ecash": "https://chronik.fabien.cash", | ||
| "bitcoincash": "https://chronik.pay2stay.com/bch" | ||
| "ecash": ["https://xec.paybutton.org", "https://chronik.fabien.cash"], |
Klakurka
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Description
Updates chronik implementation & ecashaddrjs to allow for multiple chronik URLs.
Test plan
Update your
paybutton-config.jsonso that the XEC and BCH URLs are now arrays, such as in theexample-config.json:Restart the containers and make sure it all works normally.