Conversation
lissavxo
previously approved these changes
Jul 29, 2025
chedieck
requested changes
Aug 8, 2025
Collaborator
chedieck
left a comment
There was a problem hiding this comment.
I think this excess of comments pollute the codebase and makes it hard to read, better to ask the AI to only comment when it thinks it to be really necessary.
Member
Author
|
Lissa had approved already. |
chedieck
pushed a commit
that referenced
this pull request
Sep 16, 2025
* Refactored files.ts. * Removed superfluous comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #981
Description
Refactored the 150+ line
collapseSmallPaymentsfunction inutils/files.tsto improve maintainability and readability. Extracted complex logic into aTransactionGroupManagerclass and utility functions (generateGroupKey,extractPaybuttonNames, etc.). The main function is now ~40 lines with clearer control flow. No breaking changes - public API and functionality remain identical.Test plan (suggested; go through whatever you think is worth checking)
Automated Testing
npm test tests/unittests/utils/files.test.tsnpx tsc --noEmitnpm testFunctional Testing
Edge Cases
Integration Testing