-
Notifications
You must be signed in to change notification settings - Fork 4
feat: date range filter #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: date range filter #1060
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e5515fb
feat: date range filter
lissavxo a7f91c2
fix: include endDate date range filter
lissavxo cde6623
refactor: clean up
lissavxo 4a7e16c
Merge branch 'master' into feat/date-range-filter
chedieck f7a40d6
fix: use lte instead of lt
chedieck b7671b1
Merge branch 'master' into feat/date-range-filter
chedieck 615f6ca
fix: max date on date pickers & same date for createdAt, updatedAt
chedieck 043be02
fix: backend: timezone & including last day
chedieck 8eef13e
fix: using timezone var
chedieck 5d973f7
fix: timezone on frontend
chedieck 2114ffd
test: add tests
chedieck 8b68bc0
fix: consider empty timezone edge case
chedieck 3748fdf
fix: guard against non-UTC server time
chedieck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timezone fallback bug and unhandled missing-user case
Two related concerns here:
userPreferredTimezonefallback is wrong forundefined/null:user?.preferredTimezoneisundefinedornull, the checkuserPreferredTimezone !== ''is stilltrue, sotimezonebecomesundefined/nullinstead of falling back touserReqTimezone.timezonebeing invalid while downstream code expects a usable string (or at least a well-defined default) and uses it for date-range filtering.Consider tightening the condition and adding a final default (e.g.
'UTC'):fetchUserProfileFromId(userId)throws when the profile is missing. If there are edge cases where a session exists without a user profile, this will 500 the request. If that’s possible, consider handling the error (e.g. 404 or 401) or relaxing the dependency on the profile when you only need a timezone.Also applies to: 31-33
🤖 Prompt for AI Agents