Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions public/.well-known/assetlinks.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,17 @@
"2C:D2:B8:58:40:00:21:E7:D2:1C:40:A7:CC:74:89:7C:5F:6C:68:71:21:9E:E5:31:83:C8:0B:33:D3:8B:87:48"
]
}
},
{
"relation": ["delegate_permission/common.handle_all_urls"],
"target": {
"namespace": "android_app",
"package_name": "com.cashtab.app",
"sha256_cert_fingerprints": [
"FA:C6:17:45:DC:09:03:78:6F:B9:ED:E6:2A:96:2B:39:9F:73:48:F0:BB:6F:89:9B:83:32:66:75:91:03:3B:9C",
"02:71:C6:C3:30:1F:FC:F1:E7:5E:F5:92:8D:03:A3:7C:6C:FE:33:CE:6D:22:B9:4C:8F:FF:E7:65:BE:84:04:A1",
"18:43:19:21:31:B6:EA:C3:DF:29:40:86:EA:96:6E:DE:21:D1:BE:F2:FD:B1:9C:C4:44:43:5F:94:22:D8:0F:22"
]
Comment on lines +14 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat public/.well-known/assetlinks.json

Repository: PayButton/paybutton-server

Length of output: 1273


🏁 Script executed:

find . -type f \( -name "README*" -o -name "*.md" \) | head -20

Repository: PayButton/paybutton-server

Length of output: 173


🏁 Script executed:

cat README.md

Repository: PayButton/paybutton-server

Length of output: 10201


🏁 Script executed:

git log --oneline public/.well-known/assetlinks.json | head -20

Repository: PayButton/paybutton-server

Length of output: 112


🏁 Script executed:

git show 0174388 --stat

Repository: PayButton/paybutton-server

Length of output: 22681


🏁 Script executed:

git show 0174388:public/.well-known/assetlinks.json

Repository: PayButton/paybutton-server

Length of output: 1273


🏁 Script executed:

rg -i "cashtab\|marlin" --type md --type json --type ts --type tsx -A 2 -B 2 | head -100

Repository: PayButton/paybutton-server

Length of output: 97


🏁 Script executed:

rg -i "cashtab\|marlin" -A 2 -B 2 | head -100

Repository: PayButton/paybutton-server

Length of output: 52


🏁 Script executed:

git log --all --oneline | grep -i "cashtab\|marlin\|assetlinks"

Repository: PayButton/paybutton-server

Length of output: 189


🏁 Script executed:

git show af2d13c --stat

Repository: PayButton/paybutton-server

Length of output: 339


🏁 Script executed:

git show af2d13c:public/.well-known/assetlinks.json

Repository: PayButton/paybutton-server

Length of output: 366


🏁 Script executed:

git show 0a91e41:public/.well-known/assetlinks.json

Repository: PayButton/paybutton-server

Length of output: 675


🏁 Script executed:

git log --all --format="%H %s" | grep -i "cashtab\|marlin"

Repository: PayButton/paybutton-server

Length of output: 145


🏁 Script executed:

git show 0a91e41 --stat

Repository: PayButton/paybutton-server

Length of output: 417


🏁 Script executed:

git show 0a91e41

Repository: PayButton/paybutton-server

Length of output: 1129


🏁 Script executed:

git log --all --oneline -- public/.well-known/assetlinks.json

Repository: PayButton/paybutton-server

Length of output: 223


Confirm whether Cashtab and Marlin Wallet intentionally share the signing certificate.

The fingerprint FA:C6:17:45:DC:09:03:78:6F:B9:ED:E6:2A:96:2B:39:9F:73:48:F0:BB:6F:89:9B:83:32:66:75:91:03:3B:9C is present in both app entries. This could be correct if they use a shared signing key, but if Cashtab has different release certificates, this will break app-link verification or grant the wrong app URL handling permissions. Please verify Cashtab's actual signing cert(s) and confirm whether the shared key is intentional.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@public/.well-known/assetlinks.json` around lines 14 - 23, The assetlinks.json
entry for package_name "com.cashtab.app" currently includes the
sha256_cert_fingerprint
"FA:C6:17:45:DC:09:03:78:6F:B9:ED:E6:2A:96:2B:39:9F:73:48:F0:BB:6F:89:9B:83:32:66:75:91:03:3B:9C"
which also appears in the Marlin Wallet entry; confirm whether Cashtab and
Marlin intentionally share the signing key, and if not, replace that fingerprint
in the "target" block for com.cashtab.app with the correct Cashtab release
SHA-256 fingerprint(s) (or remove any stale fingerprints), then re-generate and
redeploy public/.well-known/assetlinks.json so app-link verification uses the
correct certificate(s).

}
}
]