Conversation
chronikService, blockchainService, transactionService reorganized to avoid circular imports. Types separated into a file, complicated ad hoc utilitary functions removed
ScottMcDermid
previously approved these changes
Jan 16, 2025
Member
ScottMcDermid
left a comment
ScottMcDermid
left a comment
There was a problem hiding this comment.
Did a quick PCR, and the actual chronikService -> blockchainService swap looks good.
I skimmed the rest of the refactor, and didn't find any issues, although I'm less familiar with the codebase.
Member
|
We can merge once the tests are passing. |
chedieck
force-pushed
the
feat/chronik-rework
branch
from
c947878 to
d91fb27
Compare
Klakurka
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #918
Description
Reworks the chronik logic:
blockchainService.tsfile.chronikService.ts, allowing thus chronik to be tested with jest.MultiBlockchainClientto be used as the interface to access both eCash and Bitcoin Cash blockchains, inferred by the method arguments.Test plan
Make sure everything chronik related run seamlessly. This PR should not alter the application behavior, except for:
Missing prices for tx....which I suppose was caused by the race condition between the jobs and the chronik initialization.