Merged
Conversation
chedieck
requested changes
Mar 6, 2025
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
"Is admin?" is always true
components/Admin/RegisteredUsers.tsx
Outdated
| Header: 'Admin', | ||
| accessor: 'isAdmin', | ||
| Cell: ({ cell }: any) => ( | ||
| cell.value === undefined ? 'No' : <span className={style.admin}>Yes</span> |
Collaborator
There was a problem hiding this comment.
This is wrong, outputting 'Yes' always
chedieck
requested changes
Mar 7, 2025
components/Admin/RegisteredUsers.tsx
Outdated
| Header: 'Admin', | ||
| accessor: 'isAdmin', | ||
| Cell: ({ cell }: any) => ( | ||
| cell.value === null ? 'No' : <span className={style.admin}>Yes</span> |
Collaborator
There was a problem hiding this comment.
You should actually check id isAdmin === true to return "Yes".
Non admin users can have this attribute both as NULL or 0 in the DB (null or false after prisma)
lissavxo
force-pushed
the
feat/create-table-users-registered
branch
from
10fb4b6 to
7aee46c
Compare
Klakurka
approved these changes
Mar 9, 2025
chedieck
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #968
Description
Changed registered users table to use TableContainer component
Test plan
run server with
docker compose upcheck admin page Registered Users section