Conversation
chedieck
requested changes
Mar 6, 2025
Collaborator
Author
|
Cool good catches. I missed a few of those places, but got them in there now. And fixed the border and text color |
Klakurka
requested changes
Mar 9, 2025
Collaborator
Author
|
ah yes, added |
chedieck
approved these changes
Mar 10, 2025
Klakurka
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Related to #973
Description
The buttons throughout the app were pretty disjointed. They relied on a series of classnames, applied at each instance which was just pretty messy and causing some inconsistencies.
Adding a reusable button component here to help with this.
It also handles the display of the loading state so that is more consistent, per #973
Note: I switched the order so the 'submit' buttons are on the right side of the create and edit forms. It seems more natural that way to me, but open leaving the order alone if you disagree
Test plan
Preview the site and check the buttons in the app look and perform well