Skip to content

chore: Add button component #980

Merged
Klakurka merged 4 commits intomasterfrom
button-component
Mar 11, 2025
Merged

chore: Add button component #980
Klakurka merged 4 commits intomasterfrom
button-component

Conversation

@johnkuney
Copy link
Copy Markdown
Collaborator

Related to #973

Description

The buttons throughout the app were pretty disjointed. They relied on a series of classnames, applied at each instance which was just pretty messy and causing some inconsistencies.
Adding a reusable button component here to help with this.
It also handles the display of the loading state so that is more consistent, per #973

Note: I switched the order so the 'submit' buttons are on the right side of the create and edit forms. It seems more natural that way to me, but open leaving the order alone if you disagree

Test plan

Preview the site and check the buttons in the app look and perform well

Copy link
Copy Markdown
Collaborator

@chedieck chedieck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PayButton form margins have gone away with the changes.

Before:
image

After:
image

  1. In the wallet, "Submit" is white on blue instead of the previous black on blue:

Before:
image

After:
image

  1. "Create organization" button won't work when clicked, only if Enter is pressed.

  2. Export as CSV lost white border:

Before:
image

After:
image

@johnkuney
Copy link
Copy Markdown
Collaborator Author

Cool good catches. I missed a few of those places, but got them in there now. And fixed the border and text color

Copy link
Copy Markdown
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Organization Create button and sign in buttons don't seem to have the loading spinner when clicked.

@johnkuney
Copy link
Copy Markdown
Collaborator Author

ah yes, added

@Klakurka Klakurka merged commit 2fc3bc4 into master Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants