Conversation
7e3058c to
6699ac6
Compare
967abfe to
7821b30
Compare
Klakurka
left a comment
There was a problem hiding this comment.
The sorting doesn't work right. If you sort by value, it will give you all of one currency first, then the other (eg. XEC first, then BCH).
chedieck
left a comment
There was a problem hiding this comment.
This implementation of repeating certain info like the values and networkId in a single column of the row is really confusing and unecessary.
Check TanStack/table#571
fc0762c to
f1fe51e
Compare
redis/paymentCache.ts
Outdated
| values, | ||
| amount: tx.amount | ||
| amount: tx.amount, | ||
| networkId: tx.address.networkId |
There was a problem hiding this comment.
Still repeating info here
redis/types.ts
Outdated
| @@ -48,11 +48,18 @@ export interface ButtonDisplayData { | |||
| export interface AmountData { | |||
There was a problem hiding this comment.
AmountDatais the same of what you're now callingAmountexcept for thevalues.- in the
Paymentinterface we havevalues: AmountData, making this even more confusing AmountDatais exported even though is not used anywhere.- You're adding another column (
amount) toPayment, even though all that info is already there
This is super confusing and almost impossible to follow up. That is probably the reason why redundant columns keep stacking upon each other.
There certainly shouldn't be a Amount and AmountData interface. It has no reason to have networkId on it either, since that is also already present in the parent interface. If you need to take something from it, and if that actually makes sense, then use Omit.
7950a9b to
927df25
Compare






Related to #985
Description
Added decimals to crypto amount in payments page.
Test plan
Check amount numbers on payments page.