Merged
Conversation
lissavxo
force-pushed
the
feat/merge-addresses-button-detail
branch
from
5661236 to
98088ad
Compare
chedieck
requested changes
Apr 22, 2025
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
Alignment of columns Amount, Network, Tx and Address is wrong
| const orderDescString: Prisma.SortOrder = orderDesc ? 'desc' : 'asc' | ||
|
|
||
| let orderByQuery | ||
| if (orderBy !== undefined && orderBy !== '') { |
Collaborator
There was a problem hiding this comment.
Can you add some comments for what this code block is doing?
Collaborator
Author
|
Good catch, fixed the table and added comment |
chedieck
requested changes
May 5, 2025
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
Ordering works an it's aligned, but the little gray arrow now always shows besides the "Address" column header, despite it being ordered by another column, e.g. "Date".
Collaborator
There was a problem hiding this comment.
The name of this component should change now, since the behavior changed.
PaybuttonTransactions is more appropriate.
chedieck
previously approved these changes
May 15, 2025
chedieck
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #800 #943
Description
Merged transactions in a single table and added a column with the address in the button details screen.
Test plan