Merged
Conversation
Klakurka
requested changes
Feb 2, 2025
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
This kills support for Electrum ABC which we don't want to do.
Are we not able to put a error handler on this and open cashtab.com in that event?
Klakurka
approved these changes
Feb 6, 2025
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
After talking with a few people, consensus is that this is probably the best thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #464
Description
Open cashtab.com when ElectrumABC and Cashtab Extension is not installed
Test plan
Run
yarn dev, test send button with ElectrumABC and Cashtab Extension not installed