Merged
Conversation
Klakurka
requested changes
Feb 6, 2025
Member
There was a problem hiding this comment.
Awesome!
- I was wondering if we could use this as an opportunity to improve the QR code clicking. Right now there's no animation but a slight CSS border change that makes the whole dialog shift a few pixels. Anything better we an do there?
- Any thoughts on animations on payment success?
- Really I'd call this a nit but when the QR code takes an extra bit of time to load in (when the spinner is up and it's waiting for a server response), the QR code animation doesn't run because it's past the time when it would have completed normally. Able to make it animate in when the actual QR code is rdy or is that too much work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #227
Description
Adding some subtle animations to the dialog open, qrcode, and buttons
Test plan
preview and try it out. Let me know if you see any issues