Conversation
lissavxo
force-pushed
the
docs/op-return-feature
branch
from
fc47373 to
994c468
Compare
chedieck
requested changes
Mar 6, 2025
lissavxo
force-pushed
the
docs/op-return-feature
branch
from
40d052f to
f15b1d8
Compare
chedieck
requested changes
Mar 10, 2025
lissavxo
force-pushed
the
docs/op-return-feature
branch
from
7366a34 to
9c80879
Compare
chedieck
requested changes
Mar 21, 2025
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
Left some corrections.
Also: maybe worth it mentioning that the data payload can be at most 213 bytes (when UTF-8 encoded), if there is no paymentId, if there is the limit is 205 bytes (since the paymentId takes 8 bytes.)
docs/README.md
Outdated
|
|
||
| - `0102030405060708090a0b0c` → Data payload | ||
|
|
||
| - `08` → 8-byte value indicating that this transaction has an 8-byte payment ID |
Collaborator
There was a problem hiding this comment.
This is not a "8-byte value", it is the number 8 represented in one byte.
docs/README.md
Outdated
|
|
||
| - `08` → 8-byte value indicating that this transaction has an 8-byte payment ID | ||
|
|
||
| - `0102030405060708` → payment ID |
docs/README.md
Outdated
|
|
||
| - `00` → No data payload | ||
|
|
||
| - `08` → 8-byte value indicating that this transaction has an 8-byte payment ID |
docs/README.md
Outdated
|
|
||
| - `08` → 8-byte value indicating that this transaction has an 8-byte payment ID | ||
|
|
||
| - `0102030405060708` → payment ID |
lissavxo
force-pushed
the
docs/op-return-feature
branch
from
58656b1 to
a332169
Compare
chedieck
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #429
Description
Added a new topic on docs to describe opReturn syntax rules
Test plan
Run yarn start:docs and go to OpReturn topic