Conversation
lissavxo
force-pushed
the
feat/ignore_opreturn_bch
branch
2 times, most recently
from
aa5f331 to
579a8a2
Compare
lissavxo
force-pushed
the
feat/ignore_opreturn_bch
branch
from
579a8a2 to
f23dc8c
Compare
| const opReturn = rawOpReturnIsEmptyOrUndefined ? message : rawOpReturn | ||
| const opReturnIsEmptyOrUndefined = opReturn === '' || opReturn === undefined; | ||
|
|
||
| if(!isBCH){ |
There was a problem hiding this comment.
This is really weird.
- Identation is missing
- The first three lines of the if clause are identical to what has just been done before entering the
if (!isBCH) {...} - The last two lines of the if clause are identical to what will be done after leaving the
if (!isBCH) {...}
There was a problem hiding this comment.
should be good now
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
This works with no paymentId, but if paymentId is enabled then it won't trigger success without it. The paymendId, As far as I understood, being included in the opReturn, shouldn't matter.
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
As it is now, it works if I send the OP_RETURN without the paymentId, but not if I don't send the OP_RETURN.
As I understood, the expected behavior is: for BCH PayButtons / Widgets, completely ignore the existence of OP_RETURN.
That means that we should check if incoming transactions should be "success txs" (i.e; run onSuccess, toast, etc) solely based on the amount.
Actually got it to work, must have been something else. |
2 participants
Related to #379
Description
Ignore Op return trigger success validation on bch transactions
Test plan
Check if button is triggering success on BCH transactions with wrong OP_RETURN