Skip to content

Reduced duration on the the end of the success sound#543

Merged
Klakurka merged 1 commit intomasterfrom
feat/shortened-success-sfx
Aug 29, 2025
Merged

Reduced duration on the the end of the success sound#543
Klakurka merged 1 commit intomasterfrom
feat/shortened-success-sfx

Conversation

@Klakurka
Copy link
Copy Markdown
Member

Description

The idea with this one is to allow sites to navigate to another page quickly without having to implement an extra delay to avoid cutting off the audio early.

Test plan

  1. Make a payment triggering onSuccess and make sure the sound that plays sounds good and isn't getting cut off at the beginning and end.

Pay close attention to the first payment as subsequent payments might have the audio cached which will change how it plays a bit.

@Klakurka Klakurka requested a review from chedieck August 29, 2025 15:55
@Klakurka Klakurka self-assigned this Aug 29, 2025
@Klakurka Klakurka added the enhancement (UI/UX/feature) New feature or request label Aug 29, 2025
@Klakurka Klakurka merged commit b4effc2 into master Aug 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement (UI/UX/feature) New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants