feat: add public filters for student logout and registration ToS cust…#187
Closed
anfbermudezme wants to merge 1 commit intopearson/ulmofrom
Closed
feat: add public filters for student logout and registration ToS cust…#187anfbermudezme wants to merge 1 commit intopearson/ulmofrom
anfbermudezme wants to merge 1 commit intopearson/ulmofrom
Conversation
1 task
Author
|
We’ve concluded that these filters are not required at this time and do not provide immediate value in the current roadmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Description
This PR integrates two Open edX public filters into
edx-platformby wiring the filter invocations at the correct LMS execution points for (1) student logout and (2) registration Terms of Service (ToS) label construction. The goal is to expose stable extension points for Pearson plugins (and other downstreams) while ensuring the core user flows remain unaffected.Changes made
1. Trigger logout filter during LMS logout
openedx/core/djangoapps/user_authn/views/logout.pyLogoutView.dispatchStudentLogoutRequestedorg.openedx.learning.student.logout.requested.v12. Allow ToS label customization during registration form rendering
openedx/core/djangoapps/user_authn/views/registration_form.py_add_terms_of_service_fieldStudentRegistrationFormTermsOfServiceLabelRequestedorg.openedx.learning.student.registration.form.terms_of_service.label.requested.v1label: the default ToS label constructed by the LMSplatform_name: resolved from site configuration (PLATFORM_NAME) with a settings fallbacklabel = label_with_terms_of_service_and_privacy_policy or labelBackward Compatibility / Safety
PRs Related
Reviewers