PADV-3091: Add ENABLE_CCX_CERTIFICATES feature by sergivalero20 · Pull Request #190 · Pearson-Advance/edx-platform

sergivalero20 · 2026-02-10T13:45:45Z

Ticket

https://pearson.atlassian.net/browse/PADV-3091

Description

Added a feature flag ENABLE_CCX_CERTIFICATES to allow certificate generation for CCX (Custom Courses for edX) courses. By default, edx-platform blocks certificate generation for all CCX courses. This feature flag enables operators to opt-in to CCX certificate support without modifying the blocking logic permanently.

Changes Made

Added ENABLE_CCX_CERTIFICATES: False to the FEATURES dictionary, placed directly below the related CUSTOM_COURSES_EDX flag.
Update unit tests

How to test

Deploy edx-platform with the feature flag changes
Create a master course with:
Certificate template configured at org level
cert_html_view_enabled = True
HTML certificates enabled globally (CERTIFICATES_HTML_VIEW = True)
Create a CCX from the master course
Enroll a test student in the CCX with mode no-id-professional

Copy and parte following lines in the Django Shell:

from django.contrib.auth.models import User
from opaque_keys.edx.locator import CCXLocator
from lms.djangoapps.grades.api import CourseGradeFactory
from lms.djangoapps.grades.course_grade_factory import CourseGradeFactory
from openedx.core.djangoapps.signals.signals import COURSE_GRADE_NOW_PASSED


from unittest.mock import Mock

user = User.objects.get(username='<student_username>')
ccx_key = CCXLocator.from_string('ccx-v1:<org>+<course>+<run>+ccx@<id>')

mock_grade = Mock()
mock_grade.percent = 0.9
mock_grade.passed = True

COURSE_GRADE_NOW_PASSED.send(
    sender=None,
    user=user,
    course_id=ccx_key,
    course_grade=mock_grade,
)

After firing, verify the certificate was created:

from lms.djangoapps.certificates.models import GeneratedCertificate

cert = GeneratedCertificate.objects.filter(user=user, course_id=ccx_key).first()
if cert:
    print(f"Status: {cert.status}, Grade: {cert.grade}, Mode: {cert.mode}")
else:
    print("No certificate generated")

Squirrel18 · 2026-02-10T14:05:43Z

lms/djangoapps/certificates/tests/test_generation_handler.py

                                                         self.grade)
            assert _set_regular_cert_status(self.user, self.course_run_key, self.enrollment_mode, self.grade) is None

+    @override_settings(FEATURES={**settings.FEATURES, 'ENABLE_CCX_CERTIFICATES': False})


For readability and organization I think it's better to organize these test cases in their own class and avoid expanding the current one. @sergivalero20

Squirrel18 · 2026-02-10T14:06:52Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+            ) is None
+
+    @override_settings(FEATURES={**settings.FEATURES, 'ENABLE_CCX_CERTIFICATES': False})
+    def test_ccx_blocked_when_flag_disabled(self):


I think there is no substantial difference between this test and test_ccx_blocked_by_default. @sergivalero20

Squirrel18 · 2026-02-10T14:11:36Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        Test that CCX certificates are blocked when ENABLE_CCX_CERTIFICATES is not set (default behavior).
+        """
+        with mock.patch(CCX_COURSE_METHOD, return_value=True):
+            assert not _can_generate_regular_certificate(


These test classes are using UnitTest from the std lib: https://docs.python.org/3/library/unittest.html so I think it's better to create the assertions using assertions method (e.g. https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertEqual) instead of using Pytest-styled assertions. @sergivalero20

Squirrel18 · 2026-02-10T14:13:47Z

lms/djangoapps/certificates/generation_handler.py

    """
-    if _is_ccx_course(course_key):
+    if _is_ccx_course(course_key) and not settings.FEATURES.get('ENABLE_CCX_CERTIFICATES', False):
        log.info(f'{course_key} is a CCX course. Certificate cannot be generated for {user.id}.')


I think the message should change to highlight this change. @sergivalero20

lms/djangoapps/certificates/generation_handler.py

Squirrel18 · 2026-02-20T14:45:24Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+            mode=self.enrollment_mode,
+        )
+
+    def test_blocked_by_default(self):


I guess there is something missing here. You are not testing a CCX course here, you are testing a regular course and a disable ENABLE_CCX_CERTIFICATES, which I think could be misleading in certain ways. So I think you should run these tests with an actual CCX course, not a regular course. @sergivalero20

Since I was mocking the behavior I decided to use master course, however, you are right!
I will use CCX instead.
@Squirrel18

Thanks!.

I think you can combine test_status_blocked_by_default and test_blocked_by_default. @sergivalero20

Squirrel18 · 2026-02-20T14:46:40Z

openedx/core/djangoapps/enrollments/tests/test_api.py

            assert not result['is_active']
+
+
+@unittest.skipUnless(settings.ROOT_URLCONF == 'lms.urls', 'Test only valid in lms')


Why these tests are only valid in the LMS? @sergivalero20

@Squirrel18 ok, you're right!
The decorator is unnecessary

Squirrel18 · 2026-02-20T20:04:29Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+            mode=self.enrollment_mode,
+        )
+
+    # --- Blocked by default ---


Is this necessary? @sergivalero20

Squirrel18 · 2026-02-20T20:08:22Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        """
+        Test that CCX certificate status cannot be set when flag is not set.
+        """
+        self.assertIsNone(_set_regular_cert_status(


Isn't _can_set_regular_cert_status the one we should be testing it? @sergivalero20 and I guess the assertion is assertIsFalse, which the actual value returned.

Squirrel18 · 2026-02-20T20:08:36Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        Test that CCX certificates are blocked when ENABLE_CCX_CERTIFICATES is not set (default behavior).
+        """
+        self.assertFalse(_can_generate_regular_certificate(
+            self.user, self.ccx_key, self.enrollment_mode, self.grade


Trailing comma. @sergivalero20

Squirrel18 · 2026-02-20T20:08:45Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        Test that CCX certificate status cannot be set when flag is not set.
+        """
+        self.assertIsNone(_set_regular_cert_status(
+            self.user, self.ccx_key, self.enrollment_mode, self.grade


Trailing comma. @sergivalero20

Squirrel18 · 2026-02-20T20:10:11Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        Test that CCX certificates are blocked when ENABLE_CCX_CERTIFICATES is explicitly False.
+        """
+        self.assertFalse(_can_generate_regular_certificate(
+            self.user, self.ccx_key, self.enrollment_mode, self.grade


Trailing comma. @sergivalero20

Squirrel18 · 2026-02-20T20:12:44Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+    # --- Allowed when flag enabled ---
+
+    @override_settings(FEATURES={**settings.FEATURES, 'ENABLE_CCX_CERTIFICATES': True})
+    def test_can_generate_when_flag_enabled(self):


I think you are missing _can_set_regular_cert_status. @sergivalero20

Squirrel18 · 2026-02-20T20:12:52Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        Test that CCX certificates can be generated when ENABLE_CCX_CERTIFICATES is True.
+        """
+        self.assertTrue(_can_generate_regular_certificate(
+            self.user, self.ccx_key, self.enrollment_mode, self.grade


Trailing comma. @sergivalero20

Squirrel18 · 2026-02-20T20:13:33Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+        """
+        Test that certificate status can be set for CCX courses when ENABLE_CCX_CERTIFICATES is True.
+        """
+        GeneratedCertificateFactory(


Is this part of an integration test? @sergivalero20

Squirrel18 · 2026-02-20T20:15:33Z

lms/djangoapps/certificates/tests/test_generation_handler.py

+            self.user, regular_key, self.enrollment_mode, self.grade
+        ))
+
+    @override_settings(FEATURES={**settings.FEATURES, 'ENABLE_CCX_CERTIFICATES': True})


Are these tests necessary? you only change: _can_generate_regular_certificate and _can_set_regular_cert_status, so I don't think these are necessary for a unit test. @sergivalero20

Squirrel18 · 2026-02-20T20:17:29Z

lms/envs/common.py

+# Default enrollment mode for CCX courses when ENABLE_CCX_CERTIFICATES is True.
+# Must be a certificate-eligible mode (anything except 'audit').
+# Common choices: 'honor', 'no-id-professional', 'professional', 'verified'.
+CCX_DEFAULT_ENROLLMENT_MODE = 'honor'


Please, use the standard way to document new settings or feature toggles: https://docs.openedx.org/projects/edx-toggles/en/latest/how_to/documenting_new_feature_toggles.html

feat: add ENABLE_CCX_CERTIFICATES feature

319c5d3

sergivalero20 self-assigned this Feb 10, 2026

sergivalero20 added the feature New feature label Feb 10, 2026

sergivalero20 requested review from Squirrel18 and anfbermudezme February 10, 2026 13:45

Squirrel18 requested changes Feb 10, 2026

View reviewed changes

sergivalero20 added 2 commits February 11, 2026 00:09

feat: address comments

0fe8aaa

feat: address comments

e0cab3c

Squirrel18 reviewed Feb 20, 2026

View reviewed changes

feat: address comments

9963569

Squirrel18 requested changes Feb 20, 2026

View reviewed changes

		assert not result['is_active']


		@unittest.skipUnless(settings.ROOT_URLCONF == 'lms.urls', 'Test only valid in lms')

Comments

Conversation

sergivalero20 commented Feb 10, 2026

Ticket

Description

Changes Made

How to test

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants