Skip to content

Conversation

@eshantri
Copy link
Contributor

@eshantri eshantri commented Mar 1, 2021

Screenshot from 2021-03-01 10-20-18
In order to test this I removed "start_date" column from "input_files/experiments.csv" file and ran curl -F "fileName=@input_files/experiments.csv" \ http://localhost:5001/yaba/v1/experiments?username=guestuser , as expected it gave the following error-
Screenshot from 2021-03-01 10-44-08
I tested the same on other routes as well and all gave expected errors on missing the required columns.

@eshantri eshantri changed the title Resolved column validation #74 Resolved column validation (Issue #74) Mar 1, 2021
@im-prakher im-prakher self-requested a review March 14, 2021 14:18
@im-prakher im-prakher merged commit 16da1c2 into PecanProject:master Mar 14, 2021
@dlebauer
Copy link
Member

Thanks @eshantri !!

@im-prakher
Copy link
Contributor

im-prakher commented Apr 11, 2021

@dlebauer The linter test was first failing for this pull request whereas when I reverted this pr, the tests were running fine. Also, I created an empty test commit that was running fine on my forked repository but the same error occurred when I created the pr on YABA repo. Take a look at #88

@im-prakher
Copy link
Contributor

Is it possible, since the forked repo eshantri:master has been deleted, it might be creating trouble for upcoming PR's after this?

@dlebauer
Copy link
Member

dlebauer commented Apr 11, 2021

Certainly possible - but I think it is always okay to delete a branch after it has been merged.

it seemed to also be complaining about a missing commit / incomplete git history in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants