Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for pennbbl Docker image #870

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add warning for pennbbl Docker image #870

merged 1 commit into from
Nov 13, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 13, 2024

Closes none, but is related to #627.

Changes proposed in this pull request

  • Add a big warning if you use pennbbl/qsiprep in a container. We should remove this after releasing 0.23.0 and before releasing 1.0.0.

@tsalo
Copy link
Member Author

tsalo commented Nov 13, 2024

It seems to be working! I found this in the forrest_gump log:

**************************************************************
WARNING: The pennbbl/qsiprep Docker image has been DEPRECATED.
Please use the pennlinc/qsiprep image instead.
**************************************************************

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.53%. Comparing base (0deeee0) to head (fd85cdc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
qsiprep/cli/run.py 40.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   28.52%   28.53%   +0.01%     
==========================================
  Files          68       68              
  Lines       10146    10156      +10     
  Branches     1142     1146       +4     
==========================================
+ Hits         2894     2898       +4     
- Misses       7152     7154       +2     
- Partials      100      104       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 76cfce6 into master Nov 13, 2024
20 checks passed
@tsalo tsalo deleted the deprecate-pennbbl branch November 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants