Improve approximate set generation in qml.ops.sk_decomposition
#6855
+44
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The approximate set for the Solovay-Kitaev decomposition is currently prepared by populating a trie-based data structure (TbDS) with a BFS traversal. This is efficient but misses out on a few future gate sequences because some parent sequences are caught in the equality check condition.
Description of the Change:
Benefits: This makes the approximate set decently dense than before, unlocking efficient decomposition for some previously missing edge cases.
Possible Drawbacks: This adds a constant overhead incurred from traversing additional parent nodes and post-build pruning. However, this is negligible; as the approximate set once built is cached.
Related GitHub Issues: [sc-82463] #6131