fix(search): picker and drag handed out wrong paths for global search results - #23
Open
eliasfaltin wants to merge 1 commit into
Open
fix(search): picker and drag handed out wrong paths for global search results#23eliasfaltin wants to merge 1 commit into
eliasfaltin wants to merge 1 commit into
Conversation
… results An indexed (plocate/tracker3) search result lives in another folder and carries its absolute `path`. FilePickerBar.submit() and ActionEngine.dragMimeDataFor() joined its basename onto currentPath instead, so choosing or dragging a search hit gave the caller a file that does not exist. Both now resolve entries with Utils.entryPath, and the picker percent-encodes its URIs like the drag source already did.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A global search result (plocate/tracker3 index) lives in another folder and carries its absolute
path, withnameas the bare basename. Two places ignored thatpathand joined the basename ontoNavState.currentPathinstead:FilePickerBar.submit()— the FileChooser portal answer.ActionEngine.dragMimeDataFor()— thetext/uri-listhanded to a drop target.So picking or dragging a search hit gave the receiving app a file that does not exist. Searching for
clawdfrom~and picking~/Downloads/clawd.svgansweredfile:///home/elias/clawd.svg. Omamail reported "That file could not be read" for every attachment chosen through search, whether by the portal picker or by drag and drop. Browsing to the folder and picking the same file worked, which hid the cause.Solution
Both sites now resolve an entry with the existing
Utils.entryPath(base, entry), which returns the absolutepathfor an indexed result andjoinPath(base, name)for a normal listing or the recursive fallback. The rest of the code (thumbnails, open, reveal) already used it.The picker also builds its URIs with
Util.fileUrlinstead of"file://" + path, so a space or#in a name is percent-encoded the way the drag source already did.Verification
omarchy-file-select) and with drag and drop from the search list; both now attach the right file.qmllint -I app/qml_moduleson both files reports nothing.