Document assert_(), combine with __ASSERT_; fixup Perl_assert() #23543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Aug 7, 2025
when was this? I do the Coverity builds with |
Presumably you meant |
bram-perl
reviewed
Aug 7, 2025
This comment is not true; it may have been true once. assert.h is always included, and assert() is always supposed to be defined, since at least C89. But the code acts like it is possible to not be defined; it's not a big deal to retain that check, so I'm leaving it in.
PERL_DEB2 is too obscure for me. Simply use #ifdef DEBUGGING
This changes the white space in preparation for the next commit
Source code line numbers now have a typedef and format so that they work on a variety of platforms.
This makes the next commits smaller.
They have the same conditional, and the next commit will change that conditional and want it to apply to both.
Some assertions have caused Coverity to complain in the past, or overflowed for some platforms, so the definition of __ASSERT_ in handy.h expands to a no-op if under Coverity or the system doesn't have a normal sized macro buffer. Bring that definition here to also be the same for Perl_assert().
And fix up the documentation, adding a caution that their use can easily lead to differing behavior in DEBUGGING vs non-DEBUGGING builds. These two macros are synonymous. This documents assert_() for the first time and clarifies their usage. Thanks to Tony Cook for clarifying this for me.
tonycoz
approved these changes
Aug 13, 2025
khwilliamson
added
the
Use merge commit
|
Fixed via a285955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combined documentation now cautions about macro parameters being evaluated more than once.
Perl_assert now works correctly on platforms where LINE is not an int., and expands to a no-op under Coverity, or on systems without adequate macro buffer space.