Avoid redefining SvREADONLY_on in gv.c as that causes confusion #23902
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the previous code, it was confusing to see calls to `SvREADONLY_on`, as without being aware the macro was redefined just above this function, the reader is unlikely to be aware that here it doesn't set the SVf_PROTECT flag. We should instead define a custom-purpose macro here and use that, to make its operation much clearer.
tonycoz
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the previous code, it was confusing to see calls to
SvREADONLY_on, as without being aware the macro was redefined just above this function, the reader is unlikely to be aware that here it doesn't set the SVf_PROTECT flag.We should instead define a custom-purpose macro here and use that, to make its operation much clearer.