pp_ctl.c: Comment on 2 exceptions in pp_goto() #23979
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in GH Perl#23969, neither of these two exceptions can be reached from our test suite. The exceptions address the possibility of a subroutine without a name, which is unlikely except possibly from XS code. The exceptions immediately preceding each of the two upon which we are commenting have messages composed to include a subroutine's name. These exceptions can be reached from our test suite and are covered as of the time of this commit.
tonycoz
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in GH #23969, neither of these two exceptions can be reached from our test suite. The exceptions address the possibility of a subroutine without a name, which is unlikely except possibly from XS code.
The exceptions immediately preceding each of the two upon which we are commenting have messages composed to include a subroutine's name. These exceptions can be reached from our test suite and are covered as of the time of this commit.